Guide tool #424
Draft
Guide tool #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixes (CIDARLAB#402) * Root commit * Object naming fix, viewManagerDelegate instances * paperLayers handling fix * Menu fixes/additions Co-authored-by: Liam Murray <[email protected]> Co-authored-by: Liam Murray <[email protected]> Co-authored-by: Liam Murray <[email protected]> Co-authored-by: Liam Murray <[email protected]>
This commit fixes the style issues introduced in eef85e7 according to the output from standardjs and prettier. Details: https://deepsource.io/gh/CIDARLAB/3DuF/transform/fafe459c-d2c2-4997-9138-a80a3172f322/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Created new visualizer for guide tool Moved all old guide code generating errors into the old folder under guide
… and StateMachine
| @@ -62,6 +62,7 @@ | |||
| "vue-select": "^3.13.0", | |||
| "vuetify": "^2.5.8", | |||
| "vuex": "^3.6.2", | |||
| "webpack-build": "^1.0.1", | |||
There was a problem hiding this comment.
I'm not sure why this got added to the dependencies, please revert this back to whats in webpack-build branch.
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| <script> | |||
| import Visualiser from "./components/Visualiser.vue"; | |||
| import LayoutSidebar from "./views/layouts/SplitLayout.vue"; | |||
| import LayoutSidebar from "./views/layouts/GuideToolLayout.vue"; | |||
There was a problem hiding this comment.
We will need to create a router and make sure your app is navigable.
- Add vue router
- Add button on the design page
Comment on lines
+394
to
400
| let newlayers = []; | ||
| newlayers[0] = new Layer({ z_offset: 0, flip: false }, this.currentDevice.generateNewName("LayerFlow"), LogicalLayerType.FLOW, groupNum.toString()); | ||
| newlayers[1] = new Layer({ z_offset: 0, flip: false }, this.currentDevice.generateNewName("LayerControl"), LogicalLayerType.CONTROL, groupNum.toString()); | ||
| newlayers[2] = new Layer({ z_offset: 0, flip: false }, this.currentDevice.generateNewName("LayerIntegration"), LogicalLayerType.INTEGRATION, groupNum.toString()); | ||
| // Add model layers to current device | ||
| //Add model layers to current device | ||
| Registry.currentDevice.createNewLayerBlock(newlayers); | ||
|
|
There was a problem hiding this comment.
We can revert these changes, there's no use for them
| @@ -7,29 +7,42 @@ | |||
| </template> | |||
|
|
|||
There was a problem hiding this comment.
We can revert all the changes in this file too
Comment on lines
+7
to
8
| <v-text-field v-model="componentName" label="Name" type="input" /> | ||
| <v-btn x-small depressed @click="cancelRename"> |
There was a problem hiding this comment.
Can revert these changes too
| @@ -4,7 +4,7 @@ | |||
| <thead v-show="showRename"> | |||
| <v-col> | |||
| <v-row align-start> | |||
| <v-text-field v-model="connectionName" label="Name" type="input"> </v-text-field> | |||
| <v-text-field v-model="connectionName" label="Name" type="input" /> | |||
| protected _ComponentInfo: Component; | ||
|
|
||
| // state: 0 means false, 1 means true, 2 means no state now | ||
| protected _State: number; |
There was a problem hiding this comment.
Change into Enum : TRUE, FALSE, DONT_CARE
Comment on lines
+7
to
+9
| protected _StateList: Array<ComponentState>; | ||
| protected _ModeId: number; | ||
| protected _ModeDescription: string; |
There was a problem hiding this comment.
Change to camelCase : _StateList -> _stateList
| this._ModeId = value; | ||
| } | ||
| // return Mode ID from current Device state | ||
| get ModeId() { |
There was a problem hiding this comment.
Convert all setters and getters into camelCase
| } | ||
|
|
||
| // add a constraint list into _StateListAll | ||
| addElement(NewELement: DeviceState) { |
There was a problem hiding this comment.
Argument name should be newState that would be easier to read.
Also do JSDoc standard formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.