119 fix lifecycle/configure.py's defaults/arguments functions, does not work for @click.argument types #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are using the
.main
method to call a Click command (as opposed to.callback
which skips the Click CLI), all defaults are already calculated. As such, we don't even need to useconfigure.defaults
. Instead, I modifiedconfigure.arguments
to correctly build the Click CLI command for the.main
method usage, such that the Click CLI is used and all defaults, type conversions, and constraints and performed automatically by Click. This new modifiedconfigure.arguments
function accounts for both@click.argument
and@click.option
types, as well asis_flag=True
types.