add depth dimension to soil variables #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to check, is this backward compatible so that old parameter files
still run?
…On Wed, Jul 6, 2022 at 2:54 PM Martyn Clark ***@***.***> wrote:
Make sure all the relevant boxes are checked (and only check the box if
you actually completed the step):
- Closes #xxx (identify the issue associated with this PR)
- Code passes standard test cases (results are either bit-for-bit
identical, or differences are explained in the PR comment)
- New tests added (describe which tests were performed to test the
changes)
- Science test figures (add figures to PR comment and describe the
tests)
- Checked that the new code conforms to the SUMMA coding conventions
<https://github.com/NCAR/summa/blob/master/docs/howto/summa_coding_conventions.md>
- Describe the change in the release notes (use either
./summa/docs/whats-new.md or ./summa/docs/minor-changes.md depending
on what changed)
Added depth dimension to soil parameters. Andrew Ireson -- can you run
with your test cases and check this works for you?
------------------------------
You can view, comment on, or merge this pull request online at:
#513
Commit Summary
- 7390fe4
<7390fe4>
add depth dimension to soil variables
File Changes
(4 files <https://github.com/CH-Earth/summa/pull/513/files>)
- *M* build/source/dshare/popMetadat.f90
<https://github.com/CH-Earth/summa/pull/513/files#diff-8785ae741d6761f855b41b65e82f805bff47805080dcf5748adc349f6d1c3133>
(6)
- *M* build/source/engine/paramCheck.f90
<https://github.com/CH-Earth/summa/pull/513/files#diff-1fd0d2a953b756a32c767ef039a2b079f79358f437e8006bb47571aa8be4d762>
(6)
- *M* build/source/engine/soilLiqFlx.f90
<https://github.com/CH-Earth/summa/pull/513/files#diff-076940baa0f978415a524ef515ca5f2b975eed13c05db3c42e6533467c2ade11>
(6)
- *M* build/source/engine/vegNrgFlux.f90
<https://github.com/CH-Earth/summa/pull/513/files#diff-bf76b26606362bdf92d33656426cde9889622ad301757278b8e36d1db21358e7>
(10)
Patch Links:
- https://github.com/CH-Earth/summa/pull/513.patch
- https://github.com/CH-Earth/summa/pull/513.diff
—
Reply to this email directly, view it on GitHub
<#513>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIKARLSWSYYDCQQCFITQCLVSXXA3ANCNFSM523DQ43A>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Yes, all is backward compatible. If the parameter is a scalar variable then it is automatically copied to all layers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure all the relevant boxes are checked (and only check the box if you actually completed the step):
./summa/docs/whats-new.mdor./summa/docs/minor-changes.mddepending on what changed)Added depth dimension to soil parameters. Andrew Ireson -- can you run with your test cases and check this works for you?