Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyline_simplification: Fix Detection of Unremovable Vertices #8736

Merged
merged 5 commits into from
Feb 19, 2025
Merged

Polyline_simplification: Fix Detection of Unremovable Vertices #8736

merged 5 commits into from
Feb 19, 2025

Conversation

afabri
Copy link
Member

@afabri afabri commented Feb 12, 2025 •
edited
Loading

Summary of Changes

We missed a variation of overlapping constraints.

Release Management

@afabri afabri added this to the 5.6.3 milestone Feb 12, 2025
@afabri afabri requested review from sloriot and lrineau February 12, 2025 12:06
@afabri afabri self-assigned this Feb 12, 2025
@afabri
Copy link
Member Author

afabri commented Feb 12, 2025

I just realize that my fix marks too many vertices as unremovable.
image

@afabri
Copy link
Member Author

afabri commented Feb 13, 2025

I just realize that my fix marks too many vertices as unremovable. image

This works again.

@MaelRL MaelRL linked an issue Feb 13, 2025 that may be closed by this pull request
Polyline_simplification: misses unremovable vertices #8735
Closed
@afabri
Copy link
Member Author

afabri commented Feb 18, 2025

Successfully tested in Ic-90

@sloriot
Copy link
Member

sloriot commented Feb 19, 2025

Successfully tested in CGAL-6.1-Ic-90

@sloriot sloriot merged commit 133b48b into CGAL:5.6.x-branch Feb 19, 2025
8 checks passed
@sloriot sloriot deleted the Polyline_simplification-unremovable_bugfix-GF branch February 19, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloriot sloriot Awaiting requested review from sloriot

@lrineau lrineau Awaiting requested review from lrineau

Assignees

@afabri afabri

Labels
Bug Pkg::Polyline_simplification_2 Tested
Projects
None yet
Milestone
5.6.3
Development

Successfully merging this pull request may close these issues.

Polyline_simplification: misses unremovable vertices
2 participants
@afabri @sloriot