Incorrect rendered formulas #8732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The formula in Documentation/doc/biblio/cgal_manual.bib ``` @Article{cgal:cgm-fobbo-11, title={Fast Oriented Bounding Box Optimization on the Rotation Group $\SO(3, \mathrm{R})$}, author={Chang, Chia-Tche and Gorissen, Bastien and Melchior, Samuel}, ``` renders incorrectly (see Optimal_bounding_box/citelist.html) as there is no command `\SO` in LaTeX The formula in doc/Kernel_d/CGAL/Kernel_d/Aff_transformation_d.h ``` \pre \f$ sin_num^2 + cos_num^2 = den^2\f$ and \f$ 0 \leq e_1 < e_2 < d\f$. ``` renders in an unexpected way (see Kernel_d/classCGAL_1_1Aff__transformation__d.html) as the `_` is seen as subscript operator in LaTeX
|
Old renderings:
New renderings:
|
|
@sloriot let's just merge it in master without going through the testsuite. |
|
Successfully tested in CGAL-6.1-Ic-90 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formula in Documentation/doc/biblio/cgal_manual.bib
renders incorrectly (see Optimal_bounding_box/citelist.html) as there is no command
\SOin LaTeXThe formula in doc/Kernel_d/CGAL/Kernel_d/Aff_transformation_d.h
renders in an unexpected way (see Kernel_d/classCGAL_1_1Aff__transformation__d.html) as the
_is seen as subscript operator in LaTeX