Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cut_with_plane and new fast clip method #8721

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add cut_with_plane and new fast clip method #8721

wants to merge 1 commit into from

Conversation

sloriot
Copy link
Member

@sloriot sloriot commented Jan 28, 2025 •
edited
Loading

Replaces #6588

TODO

  • small feature page
  • rename new_clip() to clip()
  • add (new_)split()
  • add the new PMP::kernel() based on clip()
    • replace QP_solver for most interior point in 3D convex hull
  • add parallelism

@sloriot sloriot mentioned this pull request Jan 28, 2025
Closed
@MaelRL MaelRL added Not yet approved The feature or pull-request has not yet been approved. CHANGES.md not updated labels Jan 28, 2025
sloriot
sloriot commented Feb 7, 2025
View reviewed changes
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/cut_with_plane.h
}
};

// TODO here we should integrate the epsilon to reuse existing points (moving them on the grid as an option?)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually we might want to move input points in the plane and update the oriented side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CHANGES.md not updated Not yet approved The feature or pull-request has not yet been approved. Pkg::PMP Small feature TODO
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sloriot @MaelRL