Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh 3 : initial_points_generator parameter for make_mesh_3 point initialization #7798

Merged
merged 108 commits into from
Feb 5, 2025
Merged

Mesh 3 : initial_points_generator parameter for make_mesh_3 point initialization #7798

Changes from 1 commit
Commits
Show all changes
108 commits
Select commit Hold shift + click to select a range
3937c5d
Implemented make_mesh_3 param :
ange-clement Oct 13, 2023
2732dad
Fix CI
ange-clement Oct 16, 2023
bec5358
Fix CI
ange-clement Oct 16, 2023
0d0c1f3
Fix CI
ange-clement Oct 16, 2023
9fc7230
Fix CI
ange-clement Oct 16, 2023
f2af654
Use parameters instead of template
ange-clement Oct 17, 2023
268fd8b
Fix CI confusion between typedef and struct
ange-clement Oct 17, 2023
4ee4dff
Doc change + small fix
ange-clement Oct 17, 2023
c232929
Fix error when no initial_points_generator
ange-clement Oct 17, 2023
e5d2651
Fix unvoluntary copy
ange-clement Oct 17, 2023
cb71595
Doc changed example +
ange-clement Oct 18, 2023
6558190
Fixed doc
ange-clement Oct 18, 2023
91d66d0
Renamed Construct_initial_points_from_labeled_image.h
ange-clement Oct 18, 2023
23af3eb
Updated doc example snippets +
ange-clement Oct 18, 2023
932e8a2
Fix Doc missing end of description
ange-clement Oct 18, 2023
df6d1ed
Fix Doc :
ange-clement Oct 18, 2023
3ac0639
Small doc fix
ange-clement Oct 18, 2023
6955dbd
Doc operator()
ange-clement Oct 18, 2023
7eff272
Fix doc missing ref
ange-clement Oct 19, 2023
c014741
Doc add example +
ange-clement Oct 25, 2023
976e73c
Update Mesh_3/doc/Mesh_3/Mesh_3.txt
ange-clement Oct 25, 2023
ec5539e
Revision 1 :
ange-clement Oct 25, 2023
15e75d0
Small doc fix
ange-clement Oct 25, 2023
9d22242
Removed useless initialization files
ange-clement Oct 31, 2023
d7f110e
Changed InitialPointsGenerator concept :
ange-clement Oct 31, 2023
ea11f32
Doc update +
ange-clement Nov 3, 2023
455e865
Fix error
ange-clement Nov 6, 2023
ca7548b
Removed example +
ange-clement Nov 7, 2023
ca605fe
Fix doc build
ange-clement Nov 7, 2023
ec7a6ac
Added meshing parameter : initial_points
ange-clement Nov 10, 2023
c9eabbf
Fix demo errors
ange-clement Nov 10, 2023
d9f0f25
Added initial_points to the parameter doc
ange-clement Nov 13, 2023
2c9fb5c
doc
ange-clement Mar 28, 2024
e64e28d
Made initial_point parameter work with any Range
ange-clement Mar 29, 2024
5b0f1fc
Merge branch 'master' of https://github.com/CGAL/cgal into Mesh-3-rew…
ange-clement Mar 29, 2024
ae0f8f3
Finished Merge
ange-clement Mar 29, 2024
b1fb29c
InitialPointsGenerator parameter 'n' explanation
ange-clement Mar 29, 2024
da690fd
Fixed warning unused variables
ange-clement Apr 5, 2024
f2a2051
do not use deprecated include path
sloriot Apr 5, 2024
2701314
fix warnings
sloriot Apr 9, 2024
561256e
use override instead of virtual
lrineau Apr 15, 2024
cf01bdc
simplify the snippets
lrineau Apr 15, 2024
d7ea101
improve the doc sentences
lrineau Apr 29, 2024
2813d53
other changes I forgot to commit
lrineau Apr 29, 2024
fa6e044
Merge branch 'master' of https://github.com/CGAL/cgal into Mesh-3-rew…
ange-clement May 2, 2024
50dfc18
Merge branch 'Mesh-3-rework-make-mesh-point-initialization-2-aclement…
ange-clement May 2, 2024
8575f53
Doc upgrades + simplified initial_points_generator parameter + fixed…
ange-clement May 2, 2024
58d5050
Updated CHANGES.md
ange-clement May 22, 2024
2f25527
"at least n"
janetournois Sep 12, 2024
86edcf8
rename Functions to Functors
janetournois Sep 12, 2024
b754436
tell more about the "all connected components" thing
janetournois Sep 12, 2024
f09c8d9
cleaning
janetournois Sep 12, 2024
a360747
typos
janetournois Sep 12, 2024
4d40a05
doc
janetournois Sep 12, 2024
636fceb
remove the hardly readable std::tuple and use MeshDomain::Intersectio…
janetournois Sep 12, 2024
c55477c
document n
janetournois Sep 12, 2024
ce9cd9e
wip PR https://github.com/CGAL/cgal/pull/7798
janetournois Sep 17, 2024
026850c
use initial points vector
janetournois Sep 19, 2024
b574039
compilation of examples fixed
janetournois Sep 20, 2024
39254bb
introduce Dummy_initial_points_generator
janetournois Sep 20, 2024
b3a8530
use new API with named paremeter initial_points_generator in demo
janetournois Sep 24, 2024
490a6ad
update doc
janetournois Sep 24, 2024
f4e2b3d
remove useless generator() accessor
janetournois Sep 26, 2024
8d6e7f2
doc
janetournois Sep 26, 2024
f3b5333
doc
janetournois Sep 26, 2024
88457ee
make initialization logic consistent
janetournois Sep 30, 2024
76ee84e
mention features initialization in the insertion order description
janetournois Sep 30, 2024
f0ad731
cleaning
janetournois Sep 30, 2024
f3b9a5a
doc (Mael's review)
janetournois Sep 30, 2024
9645589
apply Mael's suggestions
janetournois Sep 30, 2024
7c4ab1c
remove outdated named parameter
janetournois Sep 30, 2024
883f062
Merge branch 'Mesh-3-rework-make-mesh-point-initialization-2-aclement…
janetournois Sep 30, 2024
32f147f
cleaning
janetournois Sep 30, 2024
74cd65e
move to 6.1
janetournois Sep 30, 2024
c1f2236
Merge remote-tracking branch 'cgal/master' into Mesh-3-rework-make-me…
janetournois Sep 30, 2024
4573f78
doc
janetournois Sep 30, 2024
435ea6e
doc
janetournois Sep 30, 2024
f77f9c6
Merge remote-tracking branch 'cgal/master' into Mesh-3-rework-make-me…
janetournois Oct 23, 2024
f3abf59
Merge remote-tracking branch 'cgal/master' into Mesh-3-rework-make-me…
janetournois Nov 4, 2024
75d3d30
fix unused variable warnings and add a const
janetournois Nov 5, 2024
13328c3
fix warning
sloriot Nov 6, 2024
d5203e3
doc
janetournois Nov 7, 2024
4215e18
fix CHANGES.md (lost by merge f77f9c68476de3abc9033e9f28b1b471e42c234b)
janetournois Nov 7, 2024
d08d664
Merge remote-tracking branch 'cgal/master' into Mesh-3-rework-make-me…
janetournois Nov 7, 2024
25b89cb
fix CHANGES.md
janetournois Nov 7, 2024
18a0f69
Merge remote-tracking branch 'cgal/master' into Mesh-3-rework-make-me…
janetournois Dec 5, 2024
5c70d48
actually allow tuple-like objects, and test that feature
lrineau Dec 17, 2024
79ebe7a
minor fixes
lrineau Dec 17, 2024
9803ab4
add test of initial_points_generator with a generator generating tupl…
lrineau Dec 17, 2024
820762d
proposal for a rewrite using a lamba expression as the point generator
lrineau Dec 18, 2024
e2d11a0
allow a range as parameter
lrineau Dec 18, 2024
eecff9d
add initial_points to the list of available functors for mesh initial…
lrineau Dec 18, 2024
8e5fab0
allow the initial points generator to be non-const
lrineau Dec 18, 2024
9ef32fb
remove memory leaks with VTK objects
lrineau Dec 18, 2024
51b9c4a
cleanup
lrineau Dec 18, 2024
740863c
doc review
janetournois Dec 19, 2024
7e5b9ee
rename concept with _3 postfix
janetournois Dec 19, 2024
2496122
fix missing fix
lrineau Dec 19, 2024
7f4e5b7
make doc more clear
janetournois Dec 19, 2024
1a4cc65
wip apply Laurent's reviews
janetournois Dec 19, 2024
2ed54df
add constructors documentation
janetournois Dec 19, 2024
84e55c3
fix include
janetournois Dec 19, 2024
a98101a
move tuple_like_helpers.h to STL_Extension to avoid dependency on Mesh_3
janetournois Dec 19, 2024
7e3aa09
complete move file
janetournois Dec 19, 2024
bc64faa
Laurent's review
janetournois Jan 17, 2025
c161fc1
with the point, snippet can't be found
janetournois Jan 20, 2025
1950235
remove extra point
janetournois Jan 20, 2025
1d6e305
typo
lrineau Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Mesh_3/doc/Mesh_3/Mesh_3.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,8 @@ then the `%Mesh_domain::Intersection` object (a `%tuple` with three
elements) is constructed using a call to the functor `construct_intersection`
\snippet CGAL/Mesh_3/Construct_initial_points_labeled_image.h use construct intersection
and eventually `%intersect_index` is the element \#1 of `%intersect`.
\snippet CGAL/Mesh_3/Construct_initial_points_labeled_image.h get construct intersection.
\snippet CGAL/Mesh_3/Construct_initial_points_labeled_image.h get construct intersection
.
The dimension of the underlying simplex is stored as the element \#2 of `%intersect``.

The result of the custom initialization can be seen in
Expand Down
Loading