Mesh 3 : initial_points parameter for domain point initialization #7757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ange-clement
force-pushed
the
Mesh-3-rework-make-mesh-point-initialization-aclement
branch
from
4a68df9 to
3df0c65
Compare
The example use this struct initialize_triangulation_from_labeled_image also uses it Renamed parameter initial_points to construct_initial_points
15 tasks
|
Closed because not easy to implement. PR #7798 does this better. |
sloriot
added a commit
that referenced
this pull request
Feb 5, 2025
…tialization (#7798) ## Summary of Changes Added a `initial_points_generator` parameter in make_mesh_3. With this parameter, we can use a custom functor when initializing the C3t3 complex. This functor must follow the [Initial_points_generator](https://cgal.github.io/7798/v0/Mesh_3/classInitialPointsGenerator.html) concept. Tasks: - [x] Add `initial_points_generator` parameter in `make_mesh_3` - [x] Make an example - [x] Write `Construct_initial_points_labeled_image` into a header - [x] Make `initialize_triangulation_from_labeled_image` use `Construct_initial_points_labeled_image` - [x] Change definition of concept `InitialPointsGenerator` to output `std::tuple<MeshDomain::Point_3, int dimension, MeshDomain::Index>` (instead of `std::pair<MeshDomain::Point_3, MeshDomain::Index>`) - [x] Make it pass checks - [x] Document `initial_points_generator` parameter in `make_mesh_3` - [x] Document `Construct_initial_points_labeled_image` header - [x] Document example - [x] Delete `initialize_triangulation_from_labeled_image` and `initialize_triangulation_from_gray_image` - [x] Make an example of labelled and gray image initialisation with the parameter or the old custom initialization. - [x] Make small feature page - [x] add `Construct_initial_points_gray_image.h`, similar to `Construct_initial_points_labeled_image.h` - [x] Maybe add a test ? - [x] announce in `CHANGES.md`, see #7798 (comment) ## Release Management * Affected package(s): Mesh_3 * Issue(s) solved (if any): * fix #922 * fix #7469 * discussion #7537 * previous closed PR #7757 * Feature/Small Feature (if any): [Mesh_3_initial_points_generator_parameter](https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Mesh_3_initial_points_generator_parameter) * Link to compiled documentation [*here*](https://cgal.github.io/7798/v4/Manual/index.html): * [make_mesh_3](https://cgal.github.io/7798/v4/Mesh_3/group__PkgMesh3Functions.html#gac8599a0c967075f740bf8e2e92c4770e) has been modified to receive the parameters : * [initial_points_generator](https://cgal.github.io/7798/v4/Mesh_3/group__PkgMesh3Parameters.html#gaf53777b83f1b2f3e7d49275dbab6e46b) * [initial_points](https://cgal.github.io/7798/v4/Mesh_3/group__PkgMesh3Parameters.html#gae94f38c6cd23cce45a55608e881a546a) * The [InitialPointsGenerator](https://cgal.github.io/7798/v4/Mesh_3/classInitialPointsGenerator.html) concept that the functor must be a model of. * A model of this concept : [Construct_initial_points_labeled_image](https://cgal.github.io/7798/v4/Mesh_3/structCGAL_1_1Construct__initial__points__labeled__image.html) * License and copyright ownership:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Added a
construct_initial_pointsparameter in domain creation.With this parameter, we can save a custom functor in the domain that will be used wen initializing the C3t3 complex.
This functor must follow the Construct_initial_points concept.
Tasks:
construct_initial_pointsparameter increate_labeled_image_mesh_domainmesh_hybrid_mesh_domainconstruct_initial_pointsparameter in allcreate_xx_domainofLabel_mesh_domain_3Construct_initial_points_labeled_imageinto a headerinitialize_triangulation_from_labeled_imageuseConstruct_initial_points_labeled_imageconstruct_initial_pointsparameterConstruct_initial_points_labeled_imageheaderinitialize_triangulation_from_labeled_imageandinitialize_triangulation_from_gray_imageRelease Management
initialize_triangulation_from_labeled_image()#7469, discussion Mesh_3: should initialize_triangulation_from_labeled_image be a static function of image domains? #7537