Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nef_3: Use the skipVEL parameter to ensure result is always an SFace #7274

Conversation

GilesBathgate
Copy link
Contributor

Summary of Changes

This sets the skipVEL (Skip SVertices SEdges and SLoops) parameter to true, when calling the locate method in get_visible_facet of SNC_const_decorator. Since it's trying to locate an Sface, it makes no sense for locate to match SVertices, SEdges or SLoops, and if it does the assertion in get_visible_facet will fail.

Release Management

@GilesBathgate
Copy link
Contributor Author

As was previously stated:

In commit ebd5e00 the value of true was passed to L.locate() which skips needless tests.
Applying the same change to the get_visible_facet method of SNC_const_decorator makes the assertion exception never occur.
@afabri However I am not sure if it would be correct to apply the same change here or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant