This repository was archived by the owner on Mar 25, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- h5py is newly required for post-processing pipeline
- Logging lead to a resource leak due to the logging queue not being closed - this could not be resolved with the implemented logging functionality - logging was reduced to very basic python logging, which should be fine - the previous logging was not really useful and overcomplicated things heavily
- massive refactoring of current pipeline implementation - enable use of package processof and centroid calculator in different use cases more flexible - enhance performance of centroiding by running in chunks of specific size, which gives ideal runtime of DBSCAN and Centroiding - Implementation of test cases for new CentroidCalculator class and post processing pipeline
- Parameters: epsilon, min_samples, threshold, skip - Introduced shared memory to enable changes from pymepix-viewer
…s in pymepix viewer
…processing (Pool)
… pipeline and raw postprocessing
- Write TOA data to queue - Fix post processing to ignore included toa data
…ype of files instead
…ed with the old raw converter
BenMoon
previously requested changes
Sep 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks quite good.
In general, maybe we should employ a linter like flake8
or such.
Pls check the header in each file.
…/pymepix into feature/post_processing
Implemented all suggested changes and discussed with @BenMoon in person.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of new processing pipeline: