-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shallow-water equations on the cubed-sphere miniapp #550
base: main
Are you sure you want to change the base?
Conversation
c33bf84
to
83dc762
Compare
8855b13
to
491d6ab
Compare
b28bed6
to
0136af5
Compare
7361d3d
to
a6185a2
Compare
1fa55d6
to
a653fb1
Compare
Codecov Report
@@ Coverage Diff @@
## main #550 +/- ##
==========================================
- Coverage 98.06% 96.50% -1.57%
==========================================
Files 250 234 -16
Lines 16077 15788 -289
==========================================
- Hits 15766 15236 -530
- Misses 311 552 +241
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
b7bf22b
to
8bb3766
Compare
31f2588
to
050b365
Compare
fb02c59
to
8d9ad6f
Compare
8d9ad6f
to
d2f5d15
Compare
d2f5d15
to
2ccc907
Compare
…n the cube edges The algorithm with bit manipulation was greatly inspired-by and helped-by @matteovigni Thanks-to @matteovigni
…l coordinate systems on different panels (faces) of the cube
… and add compatibility macro
…FunctionSetContenxt after PR#596
Still need some debugging
This generic restriction matrix does not only have 1's but also the coordinate transformations needed from the coord system of the nodes that are on the panel edges (lat, long) to the local ones of the nodes on the adjacent panels
94234d0
to
da12e01
Compare
@LeilaGhaffari , @jedbrown , I don't know if anyone is planning to potentially continue this work. But I guess it is ok to close for now? (Can always be restored, if desired) |
I think it's worth leaving this PR open so the branch is saved. It may be that a fresh effort would start from FYSA, we have a new SciDAC to develop models for compound flooding. Our effort at present is using finite volume methods (and will express them using libCEED for GPU efficiency), but we would like to compare FE methods. It's on unstructured grids and our tests thus far are regional (rather than global), but I expect some of the work in this branch will be useful. |
This is a WIP PR for the development of the shallow-water equations solver miniapp.
Note: This PR moves the
fluids/navierstokes
miniapp into the subdirectoryfluids/navier-stokes/navierstokes
(relativeMakefile
and.gitignore
files already updated, as well astests/junit.py
andtests/tap.sh
).TODOs:
TESTARGS
test run options for CI