fix(sycl): Replaces pragma once with include guards #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd double check the other Sycl JiT files Note - I'm out next week and won't be approving anything |
jeremylt
approved these changes
Oct 27, 2024
jrwrigh
force-pushed
the
jrwrigh/fix_sycl
branch
from
9aa3e1a
to
37d37c9
Compare
OpenCL doesn't really like pragma once evidently. I think we've been 'getting away' with it previously as the JIT processing automatically doesn't allow for nested includes, but the same is not done for <ceed/types.h>?
jedbrown
force-pushed
the
jrwrigh/fix_sycl
branch
from
37d37c9
to
7f836c3
Compare
|
Rebased after merging #1703 |
jeremylt
reviewed
Nov 5, 2024
| @@ -7,7 +7,8 @@ | |||
|
|
|||
| /// @file | |||
| /// Public header for types and macros used in user QFunction source code | |||
| #pragma once | |||
| #ifndef CEED_QFUNCTION_DEFS_H | |||
There was a problem hiding this comment.
Small note - I've seen some people recommend both. Not sure I fully understand the argument why though
There was a problem hiding this comment.
Yeah, both is a bit perplexing... Maybe to avoid possible guard name conflicts?
There was a problem hiding this comment.
I think for a while #pragma once gave faster compile times, but nowadays that's less of a factor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenCL doesn't really like pragma once evidently. I think we've been 'getting away' with it previously as the JIT processing automatically doesn't allow for nested includes, but the same is not done for <ceed/types.h>?