Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor - drop unneeded casts #1667

Merged
merged 4 commits into from
Sep 20, 2024
Merged

minor - drop unneeded casts #1667

merged 4 commits into from
Sep 20, 2024

Conversation

jeremylt
Copy link
Member

oops

@jrwrigh
Copy link
Collaborator

jrwrigh commented Sep 19, 2024

For the errors on Noether in the fluids example:

[WARNING] yaksa: 1 leaked handle pool objects

I've only recently seen those on Aurora. Possibly due to latest PETSc main?

@jeremylt
Copy link
Member Author

Yeah, looks like PETSc is leaking something somewhere maybe? Its for all PETSc examples

@jeremylt
Copy link
Member Author

jeremylt commented Sep 19, 2024

This isn't expressing in Ratel CI - I wonder if there's something fishy with the int64 builds on Noether? Or maybe a package included?

@jeremylt
Copy link
Member Author

Hmm, tried setting the opt flags to O2 since MPI is supposed to clean up everything at higher optimization levels, but it doesn't seem to have helped. This error is, according to my initial research, supposed to show when there is a missing MPI_Type_Free pmodels/yaksa#254

@jeremylt
Copy link
Member Author

jeremylt commented Sep 20, 2024

Confirmed, this only occurs for the int64 build, and not the int32 build, and this is with and without HIP that we see the issue

@jeremylt jeremylt merged commit d2c752c into main Sep 20, 2024
28 checks passed
@jeremylt jeremylt deleted the jeremy/drop-cast branch September 20, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants