Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example leaks #1651

Merged
merged 9 commits into from
Aug 29, 2024
Merged

Example leaks #1651

merged 9 commits into from
Aug 29, 2024

Conversation

jeremylt
Copy link
Member

@jeremylt jeremylt commented Aug 27, 2024 •
edited
Loading

Fixing memory leaks in the examples, hopefully helps with the HIP tests on Noether

Checked

  • examples/ceed
  • examples/dealii
  • examples/fluids
  • examples/mfem
  • examples/nek
  • examples/petsc
  • examples/solids

@jeremylt jeremylt self-assigned this Aug 27, 2024
@rezgarshakeri
Copy link
Collaborator

I saw one for loop using CeedInt, any reason why it is not PetscInt?

@jeremylt
Copy link
Member Author

Which loop? I don't see a loop starting with for (CeedInt...)?

@rezgarshakeri
Copy link
Collaborator

https://github.com/CEED/libCEED/pull/1651/files#diff-b9ec863dad1f654f6b87f7fe59d030831acfcd35d6331fb85b58a60073bd4417L184

@jeremylt
Copy link
Member Author

Ah. No clue. It wasn't part of the diff so I didn't notice it.

@jeremylt jeremylt merged commit 29a534d into main Aug 29, 2024
23 of 24 checks passed
@jeremylt jeremylt deleted the jeremy/leaks branch August 29, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrwrigh jrwrigh jrwrigh approved these changes

Assignees

@jeremylt jeremylt

Labels
1-In Review examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremylt @rezgarshakeri @jrwrigh