Skip to content

Fixed float to integer punning in nanoprintf.c #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed float to integer punning in nanoprintf.c #590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions src/libc/nanoprintf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,11 +485,16 @@ static int npf_fsplit_abs(float f, uint64_t *out_int_part, uint64_t *out_frac_pa
grisu2 (https://bit.ly/2JgMggX) and ryu (https://bit.ly/2RLXSg0)
are fast + precise + round, but require large lookup tables. */

#if 0
uint32_t f_bits; { // union-cast is UB, let compiler optimize byte-copy loop.
char const *src = (char const *)&f;
char *dst = (char *)&f_bits;
for (unsigned i = 0; i < sizeof(f_bits); ++i) { dst[i] = src[i]; }
}
#else
uint32_t f_bits;
__builtin_memcpy(&f_bits, &f, sizeof(uint32_t));
#endif

int const exponent =
((int)((f_bits >> NPF_MANTISSA_BITS) & ((1u << NPF_EXPONENT_BITS) - 1u)) -
Expand Down Expand Up @@ -549,12 +554,17 @@ static int npf_fsplit_abs(float f, uint64_t *out_int_part, uint64_t *out_frac_pa
}

static int npf_ftoa_rev(char *buf, float f, char case_adj, int *out_frac_chars) {
uint32_t f_bits; { // union-cast is UB, let compiler optimize byte-copy loop.
char const *src = (char const *)&f;
char *dst = (char *)&f_bits;
for (unsigned i = 0; i < sizeof(f_bits); ++i) { dst[i] = src[i]; }
}

#if 0
uint32_t f_bits; { // union-cast is UB, let compiler optimize byte-copy loop.
char const *src = (char const *)&f;
char *dst = (char *)&f_bits;
for (unsigned i = 0; i < sizeof(f_bits); ++i) { dst[i] = src[i]; }
}
#else
uint32_t f_bits;
__builtin_memcpy(&f_bits, &f, sizeof(uint32_t));
#endif

if ((uint8_t)(f_bits >> 23) == 0xFF) {
if (f_bits & 0x7fffff) {
for (int i = 0; i < 3; ++i) { *buf++ = (char)("NAN"[i] + case_adj); }
Expand Down
Loading