change metadata lists to use dl and dd #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
does not go into as much depth about rvm lists dependency information
there are some TODOs left in here, but it's taking shape!
not sure that this is the way that it will ultimately be but I took some broad strokes at it
I left out some parts with high complexity, or explaining files like application.scss and application.js, which I feel are somewhat self-documenting. We can add that back if wanted!
since introduction of sections routes and internationalization, our link helpers look different. For basics like link and image helpers, too, we don't need to rewrite the rails docs
I decided that since they are all in there, it doesn't make sense to have it at all
erases early attempt to have configuration subdirectory of docs
Bugfixes
imitates sites like Cody Archive and Transmississippi which have essentially search result views with pagination but without being able to add additional filters, date ranges, etc
prefix_path previously only accepted named routes such as "search_path" but if the named path wasn't known, then it's been altered to accept a hash of parameters / options to select the route instead this is not necessarily an ideal solution and it has not been tested with @Sections
slight update to installation instructions
# Conflicts: # CHANGELOG.md # lib/generators/orchid_setup_generator.rb # lib/generators/setup_generator.rb
Fix/favicon
adds role=button to anchor tags which are styled as a button
corrected a small typo
Put link_tree ../images back with 4.x defaults as the two 3.x lines are the only difference from the 4.x default manifest
Fix check response
This reverts commit e6be882.
add favicon folder to Orchid manifest file
Fix error on pages which use browse_facet, e.g. /browse/collection Use more robust .blank? check for nil
Fix handling of check_response
techgique
requested changes
Apr 4, 2022
There was a problem hiding this comment.
The markup looks great, but some accompanying CSS changes are going to be necessary as the elements display as blocks and fill the full width of their container. It might be as simple as changing them to display inline in these contexts, but I'm not certain that will be all that's necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213 (I don't know if I got everything)