Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

descriptive term list rather than li for metadata #213

Open
jduss4 opened this issue Nov 10, 2020 · 2 comments · May be fixed by #275
Open

descriptive term list rather than li for metadata #213

jduss4 opened this issue Nov 10, 2020 · 2 comments · May be fixed by #275
Assignees
@karindalziel @jduss4 @techgique @wkdewey
Labels
a11y Accessibility bugsquash discuss enhancement question
Milestone
Accessibility audit

Comments

@jduss4
Copy link
Contributor

jduss4 commented Nov 10, 2020

Currently, our metadata looks like something:

<ul>
  <li><strong>Term:</strong> Text goes here</li>
</ul>

Perhaps this should instead use a dl / dt / dd solution. Consider pros and cons and accessibility
@jduss4 jduss4 added this to the 3.1 milestone Nov 10, 2020
@wkdewey wkdewey self-assigned this Jan 7, 2022
@wkdewey
Copy link
Contributor

wkdewey commented Jan 7, 2022

Dl/dt/dd is more semantically appropriate for metadata. Some accessibility concerns have been raised but overall it seems compatible with accessibility, see for instance MDN documentation

@wkdewey wkdewey mentioned this issue Mar 10, 2022
Closed
@wkdewey
Copy link
Contributor

wkdewey commented May 11, 2022

Note that Greg requested changes on the above PR

@wkdewey wkdewey modified the milestones: 3.2, Next release May 16, 2022
@wkdewey wkdewey linked a pull request Nov 21, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karindalziel karindalziel

@jduss4 jduss4

@techgique techgique

@wkdewey wkdewey

Labels
a11y Accessibility bugsquash discuss enhancement question
Projects
None yet
Milestone
Accessibility audit
Development

Successfully merging a pull request may close this issue.

Descriptive terms CDRH/orchid
change metadata lists to use dl and dd CDRH/orchid
5 participants
@karindalziel @jduss4 @techgique @erinchambers @wkdewey