Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove dev7 #7229

Merged
merged 1 commit into from
Jan 30, 2024
Merged

chore: remove dev7 #7229

merged 1 commit into from
Jan 30, 2024

Conversation

alismx
Copy link
Collaborator

@alismx alismx commented Jan 29, 2024 •
edited
Loading

DEVOPS PULL REQUEST

Related Issue

Changes Proposed

  • This removes all configs and references of dev7.

Additional Information

  • Dev7 was deleted (terraform apply -destroy) after reviewing the terraform plans (terraform plan -destroy) for ops/dev7 and ops/dev7/persistent/ and determining no other environments would be impacted.
  • If anybody sees references to dev7 in the wiki or other documentation, please feel free to call it out here or remove it.

Testing

  • Double-check that all jobs work.

Checklist for Primary Reviewer

Infrastructure

  • Consult the results of the terraform-plan job inside the "Terraform Checks" workflow run for this PR. Confirm that there are no unexpected changes!

Security

  • Changes with security implications have been approved by a security engineer (changes to authentication, encryption, handling of PII, etc.)
  • Any dependencies introduced have been vetted and discussed

Cloud

  • Oncall has been notified if this change is going in after-hours
  • If there are changes that cannot be tested locally, this has been deployed to our Azure test, dev, or pentest environment for verification

Documentation

  • Any changes to the startup configuration have been documented in the README

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

emyl3
emyl3 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the cleanup!
the tfsec task failing looks to be unrelated: https://github.com/CDCgov/prime-simplereport/actions/runs/7702949588/job/20992332711?pr=7229

fzhao99
fzhao99 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we may need a corresponding cleanup on the static site in case you don't already have it on your radar, but otherwise lgtm

@alismx alismx mentioned this pull request Jan 30, 2024
Merged
5 tasks
@alismx alismx added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit b551b21 Jan 30, 2024
47 checks passed
@alismx alismx deleted the alis/6968 branch January 30, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzhao99 fzhao99 fzhao99 approved these changes

@emyl3 emyl3 emyl3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alismx @emyl3 @fzhao99