Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand ValueSet insertion function to be more fault tolerant for concept-level insertion failures #58

Closed
fzhao99 opened this issue Oct 24, 2024 — with Linear · 1 comment

Comments

Copy link
Collaborator

fzhao99 commented Oct 24, 2024

Our current insertValueSet function added in this PR inserts related concepts and concept joins in addition to the individual valueset-level insertion. When discussing how to make this operation more fault tolerant, we mentioned configuring a retry for the number of associated concepts that get farmed out in insertion. This ticket captures that work.

One possible solution is the following. After the associated concepts for a given ValueSet have attempted to be inserted, we can do a read for whether all the concepts are in the database (either because of that insertion or from a previous valueset). If there's a mismatch, try the whole insertion again.

Acceptance Criteria

There exists a check for whether all the concepts for a given valueset have been inserted. A retry mechanism fires in the event that there's a mismatch.

@fzhao99 fzhao99 added the Improvement label Oct 28, 2024 — with Linear
@fzhao99 fzhao99 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant