Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace named iterator for priors with Dict objects #72

Closed
SamuelBrand1 opened this issue Feb 23, 2024 · 0 comments · Fixed by #73
Closed

Replace named iterator for priors with Dict objects #72

SamuelBrand1 opened this issue Feb 23, 2024 · 0 comments · Fixed by #73

Comments

@SamuelBrand1
Copy link
Collaborator

Current API

structs with information about prior(s) currently hold those as NamedTuple objects.

Problem

Although, using NamedTuples is convenient; they are annoying to strongly specify their type. However, following #65 we now will error if the object giving distribution information about priors cannot be parsed as a Symbol => D where D <: Distribution pair.

Solution

Rather than holding information on priors as NamedTuples, replace with Dict{Symbol,D} in parameteric typed struct (e.g. where D <: Distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants