Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiate CFA's Epidemia-For-Flu Model Via MSR #135

Closed
AFg6K7h4fhy2 opened this issue May 28, 2024 · 4 comments
Closed

Instantiate CFA's Epidemia-For-Flu Model Via MSR #135

AFg6K7h4fhy2 opened this issue May 28, 2024 · 4 comments
Assignees
Labels
model related to models created using pyrenew

Comments

@AFg6K7h4fhy2
Copy link
Collaborator

AFg6K7h4fhy2 commented May 28, 2024

Goal

Verify that DHM's influenza forecasting repository cfa-forecast-renewal-epidemia, which utilizes epidemia, can be instantiated via MSR.

Context

Utility from the multisignal-epi-inference repository is derived from being able to modularly construct renewal processes. One renewal model that should be able to be specified via MSR tools is the aforementioned cfa-forecast-renewal-epidemia. This port-over process, in expectation, might allow MSR developments to identify structural inadequacies or missing features and or usage capabilities.

Required Features

  • Create quarto walk-through detailing the port-over steps and providing documentation.
  • Validate MSR implemented cfa-forecast-renewal-epidemia via simulation and fitting on NHSN data, which is the data cfa-forecast-renewal-epidemia has historically been used on.

Out Of Scope

  • Non-epidemia related MSR-implementations of renewal processes.
  • epidemia beyond the scope of what's captured in cfa-forecast-renewal-epidemia.

Related documents

@seabbs
Copy link
Collaborator

seabbs commented May 29, 2024

DHM's implementation of Epidemia.

I interpreted this as @dylanhmorris implementation of the tool epidemia but I know the meaning is the use of epidemia for flu forecasting. I imagine everyone is on the same page but perhaps worth a reword for clarity.

Making this point as reimplementing all of epidemia is a much bigger task than the quite simple model that ended up being used for flu.

Validate MSR implemented Epidemia model with NHSN data

It seems like if seeking to duplicate a new implementation should be validated against the old one rather than just against old data (i.e via simulation)

@AFg6K7h4fhy2
Copy link
Collaborator Author

@seabbs

Thank you for the feedback, Sam. I've edited the issue. Wrt your first point, I think [that the target is a private repository] affected my wording, i.e I tried to cloak cfa-forecast-renewal-epidemia. Wrt the second point, this was simply a lack of detail on my end.

@AFg6K7h4fhy2
Copy link
Collaborator Author

AFg6K7h4fhy2 commented May 31, 2024

After some conversation {DHM, DamonB, GeorgeVY, me}, it has been decided, with moderate strength, to contain this port-over-implementation in the tutorials folder "for the time being".

@damonbayer damonbayer modified the milestones: 🦩 Kakuru, L Sprint Jun 10, 2024
@damonbayer damonbayer modified the milestones: 🐺 Lycorhinus, M Sprint Jun 21, 2024
@damonbayer damonbayer added model related to models created using pyrenew and removed development task labels Jul 12, 2024
@damonbayer damonbayer modified the milestones: N Sprint, O sprint Jul 19, 2024
@damonbayer damonbayer modified the milestones: 🦆 Olorotitan, P Sprint Aug 2, 2024
@damonbayer damonbayer modified the milestones: P Sprint, Q Sprint Aug 19, 2024
@AFg6K7h4fhy2
Copy link
Collaborator Author

The model has, more or less, been instantiated; it can be found here https://github.com/CDCgov/pyrenew-flu-light. Evaluate and further refinement in progress, see this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model related to models created using pyrenew
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants