This repository has been archived by the owner on Jun 16, 2021. It is now read-only.
Report handler #31
Merged
Report handler #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… autocomplete of samples
…y and fix problem with file storage
zelzhan
requested review from
thealphadollar and
canihavesomecoffee
and removed request for
thealphadollar
thealphadollar
suggested changes
Sep 1, 2020
libs/api-implementation/orchestration/src/lib/services/orchestration.service.ts
Outdated
Show resolved
Hide resolved
libs/frontend/test-entry/src/lib/components/create-test-entry/create-test-entry.component.ts
Show resolved
Hide resolved
|
Sorry for being late for your responses. Having hard times because of my studies 🙂 |
…e run of the tests was successful.
|
Now if in front of each entry, there is the status: was it successful or not. And if there are any of the test entries that fail, it will show that the test run was not successful. |
thealphadollar
approved these changes
Sep 20, 2020
There was a problem hiding this comment.
@zelzhan This PR looks good to be merged, can we please merge this?
A lot of great work has been done in this 🔥
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, so this is my last PR for the GSoC period. And the biggest one though.
So, what's new?
wrong.txtfile so that ccx_testsuite will always upload the file to the platformSorry for adding such a gigantic Pull Request, but I was running out of time and each of those features are blocking each other.
There needs to be done some more iterations on the project before it can be full integrated.
I have raised the following issues regarding the next steps:
#16 Make the categories not hardcoded and store in the db
#17 Functionality to create and delete category
#18 Functionality to modify existing test-entry.
#19 Add e2e tests testing
#20 Restrict the file extensions, when samples and output files are uploaded.
#21 Tslint configuration to handle console.debug
#22 Deep refactoring on frontend
#23 Increase test coverage
#24 Which CI on specific-test run are passed
#25 Add home page
#26 Redirect on sample upload
#27 Redirect on test entry creation
#28 Separate each test run artifacts from each other
Please refer to #30 for the detailed documentation.
Here is the small demo for my 3rd coding period on GSoC:
https://www.youtube.com/watch?v=G9_CkFo75oE&feature=youtu.be