-
Notifications
You must be signed in to change notification settings - Fork 460
[FEAT] added demuxer
module
#1662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[FEAT] added demuxer
module
#1662
Conversation
@steel-bucket Is it still WIP? |
Yes, I'm done with the hard part though, file_functions module is fully tested and ready. And the demuxer module just needs a couple more tests. Then I just have the gxf one to do. It won't be long though. Sorry to be late with it, I had some exams which are cleared out now. |
demuxer
moduledemuxer
module
demuxer
moduledemuxer
module
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 9e2a594...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Check the result page for more info. |
Hi, @prateekmedia the builds and tests are all working(other than regression). Please review it if time permits. Also should I squash the commits together? |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
In this PR, I have attempted to port the large
demuxer
module to Rust, the primary logic of the heavily interconnected C librariesfile_functions.c
,ccx_gxf.c
,ccx_demuxer.c
and their corresponding header files has aleady been implemented here. There's one more small C library, theccx_demuxer_mxf.c
but It was not connected to this, so it could be easily implemented later. I am using a step by step method in which the first step is to uselibc
to write all the logic, which I have done here. After this I have replacedlibc
wherever it is used with inbuilt rust functions to ensure memory safety. Only after that I have directly called them through C and then writing tests. This PR was inspired by the ones done for the 708 Decoder in CCextractor.By the way, the tests are fully working when run with
cargo test -- --test-threads=1
but not with onlycargo test
. As it may slow down the build process I'll not insert that into the workflow.Any criticism or suggestion is wholeheartedly welcome.