Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add share module in lib_ccxr #1651

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

steel-bucket
Copy link

@steel-bucket steel-bucket commented Jan 5, 2025

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

{pull request content here}
This PR migrates the sharing service used by the cctranslate service. The first draft was added on 5/1/2025. The new rust Implentation is in /src/rust/lib_ccxr/src/share/.

Changes Made

  • The Rust file containing the main translated logic is in /src/rust/lib_ccxr/src/share/share.rs
  • The Rust file /src/rust/lib_ccxr/src/share/tests.rs contains some preliminary tests.
  • The File /src/rust/src/libccxr_exports/share.rscontains the C bindings, as per doc specification
  • The nanomsg library for rust is being used in this code, just like the nanomsg library is used in the C code. The tests have all ran successfully, although I feel like that the current tests may not be enough to test it out completely.
  • I've also made some changes in the build commands of Linux and Mac to make them build successfully. It does for Linux, as far as I've tested.

@steel-bucket steel-bucket changed the title [FEAT] Add share module in lib_ccxr [FEAT] Add share module in lib_ccxr Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant