-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Always write 2 bytes for UTF-16BE #1571
Conversation
@canihavesomecoffee @cfsmp3 This PR is ready for review. |
@erankor Can you confirm if this works for you, or we have to do something else here? |
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit bce63b8...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info. |
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit f08febf...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info. |
I think this might not be correct solution, closing the PR. |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Related to: #1451