Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Edit Start Time of beacon #99

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Feature: Edit Start Time of beacon #99

wants to merge 5 commits into from

Conversation

ItsAdityaKSingh
Copy link

Fixes #98

  • Added startsAt argument in changeBeaconDuration mutation to allow users to even edit the start time of a beacon as and when required.
  • Also, added a conditional statement to pass error message when given starting time is after expiring time while using createBeacon mutation.

@ItsAdityaKSingh
Copy link
Author

@aadibajpai Please review these changes with your convenience so that I could work on implementing it in front-end too :)

@ItsAdityaKSingh
Copy link
Author

ItsAdityaKSingh commented Jun 27, 2022 •
edited
Loading

@Aadeesh11 Could you please review these changes for introducing a start time to be able to edit beacon details post-creation!

@Aadeesh11 Aadeesh11 requested a review from aadibajpai June 27, 2022 09:51
Aadeesh11
Aadeesh11 reviewed Jun 27, 2022
View reviewed changes
graphql/resolvers.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aadeesh11 Aadeesh11 Aadeesh11 left review comments

@aadibajpai aadibajpai Awaiting requested review from aadibajpai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mutation to edit the Start time of a beacon
2 participants
@ItsAdityaKSingh @Aadeesh11