Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: armor and inv as HUD components #4165

Open
wants to merge 5 commits into
base: nextgen
Choose a base branch
from
Open

feat: armor and inv as HUD components #4165

wants to merge 5 commits into from
+324 −7

Conversation

MukjepScarlet
Copy link
Contributor

@MukjepScarlet MukjepScarlet commented Oct 14, 2024 •
edited
Loading

image

resolves #2252

Sadly it can't support enchantment effects now.

@MukjepScarlet MukjepScarlet marked this pull request as ready for review October 15, 2024 07:19
@1zun4 1zun4 requested a review from SenkJu October 15, 2024 09:43
@ccetl
Copy link
Contributor

ccetl commented Oct 16, 2024

You could display the crafting slots too when MoreCarry is enabled.

@MukjepScarlet
Copy link
Contributor Author

OK, about an hour later.

@MukjepScarlet
Copy link
Contributor Author

image

@1zun4 1zun4 added this to the 0.17.0 milestone Oct 18, 2024
superblaubeere27
superblaubeere27 reviewed Oct 26, 2024
View reviewed changes
Copy link
Contributor

@superblaubeere27 superblaubeere27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice frontend code. If you are motivated, you could add the glint animation. You can get the frames from here and create a video from it. You can use the mask-image feature of CSS to mask out that part of the glint you need for that item and put it on the item.

src/main/kotlin/net/ccbluex/liquidbounce/features/module/modules/render/ModuleHud.kt Outdated Show resolved Hide resolved
src/main/kotlin/net/ccbluex/liquidbounce/event/events/PlayerEvents.kt Outdated Show resolved Hide resolved
@MukjepScarlet
Copy link
Contributor Author

MukjepScarlet commented Oct 27, 2024 •
edited
Loading

There are 4 existing problems:

  1. the items are abnormally darken
  2. the enchantment mask pictures are from a different repository
  3. the mask pictures are not transparent, so I have to set the opacity and brightness with CSS
  4. It sometimes doesn't work in game, disappear and appear unexpectedly, but normal in dev (Chrome latest)

@MukjepScarlet MukjepScarlet marked this pull request as draft October 27, 2024 09:23
superblaubeere27
superblaubeere27 approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@superblaubeere27 superblaubeere27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that you don't need to do that thing with the enchantment effect

@MukjepScarlet
Copy link
Contributor Author

image
Replaced with CSS effect.

@MukjepScarlet MukjepScarlet marked this pull request as ready for review October 29, 2024 12:43
@1zun4 1zun4 modified the milestones: 0.17.0, 0.18.0 Nov 4, 2024
@1zun4
Copy link
Member

1zun4 commented Nov 5, 2024

PR on hold and waiting for completion of #3884

@1zun4 1zun4 removed this from the 0.18.0 milestone Nov 5, 2024
@MukjepScarlet
Copy link
Contributor Author

I also planned to add an EnderChestView as a component, it could be easy.

@superblaubeere27
Copy link
Contributor

image Replaced with CSS effect.

Good work 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superblaubeere27 superblaubeere27 superblaubeere27 approved these changes

@SenkJu SenkJu Awaiting requested review from SenkJu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Visual Extension
4 participants
@MukjepScarlet @ccetl @1zun4 @superblaubeere27