Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-2418 Update Submission Requests URL #641

Open
wants to merge 2 commits into
base: 3.3.0
Choose a base branch
from
Open

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Mar 6, 2025

Overview

This PR renames the Submission Request URL from "/submission[s]" to "/submission-request[s]", and provides a SEO-friendly redirect within our Nginx config.

Warning

Some notes about the Nginx redirect:

  • The redirect only works when navigating from an external browser action, such as a bookmark or link from another application. Any outdated links from within our application will result in a 404 page, but I think I updated every outdated reference.
  • The redirect will forward any query parameters for the list page only (e.g. applied filters). I didn't forward the query params on the individual submission-request URL since I don't think we use them there.

Change Details (Specifics)

  • Rename /submissions and /submission/{_ID} to /submission-requests and /submission-request/{_ID}, respectively
  • Create SEO-friendly (HTTP 301) redirects from the old URLs to the new ones
  • Update all application-level references to the outdated URLs
  • Remove the homepage redirect to submission requests after login (I don't think it was ever supposed to do that?)

Related Ticket(s)

CRDCDH-2418 (FE Task)
CRDCDH-2385 (US)

@amattu2 amattu2 added this to the 3.3.0 milestone Mar 6, 2025
@coveralls
Copy link
Collaborator

coveralls commented Mar 6, 2025

Pull Request Test Coverage Report for Build 13704597062

Details

  • 1 of 13 (7.69%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.271%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Questionnaire/FormContainer.tsx 0 1 0.0%
src/content/questionnaire/sections/A.tsx 0 1 0.0%
src/content/questionnaire/ListView.tsx 1 3 33.33%
src/content/questionnaire/FormView.tsx 0 8 0.0%
Totals Coverage Status
Change from base Build 13701700680: 0.0%
Covered Lines: 4372
Relevant Lines: 6835

💛 - Coveralls

@amattu2 amattu2 marked this pull request as ready for review March 7, 2025 14:26
@amattu2 amattu2 requested a review from Alejandro-Vega March 7, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants