Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-2269 Refactor Footer Components, Replace Newsletter Topic #609

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jan 28, 2025

Overview

This PR does some limited refactoring of the footer components (Desktop, Tablet, Mobile), and abstracts the Newsletter form to a separate component. Additionally, this updates the incorrect Newsletter Topic ID from CCDI with a new one dedicated to CRDC.

Change Details (Specifics)

  • Update the incorrect CCDI topic id
  • Cleanup of the different footer components, mostly removing the index-based React keys
  • Fix the DesktopFooter using a div element instead of footer
  • Abstract the form and validation to a separate (unstyled) component
  • Add test coverage for the different components (rendering the correct footer, accessibility, and form expectations)

Related Ticket(s)

CRDCDH-2269 (Task)
CRDCDH-2204 (US)

@amattu2 amattu2 added this to the 3.2.0 (PMVP-M3) milestone Jan 28, 2025
Fixes the test coverage because isValidEmail fails first
@coveralls
Copy link
Collaborator

coveralls commented Jan 28, 2025

Pull Request Test Coverage Report for Build 13159730519

Details

  • 42 of 42 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 59.238%

Totals Coverage Status
Change from base Build 13159705909: 0.7%
Covered Lines: 4142
Relevant Lines: 6554

💛 - Coveralls

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@amattu2 amattu2 marked this pull request as ready for review January 29, 2025 14:21
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The footer is still working as expected, and all the cleanup is really well done. Great job!

@Alejandro-Vega Alejandro-Vega merged commit 9237c02 into 3.2.0 Feb 5, 2025
5 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-2269 branch February 5, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants