-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRDCDH-2187 Submission Request Cancel/Restore #602
Conversation
Pull Request Test Coverage Report for Build 13159651953Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks solid to me. Great work! Also, I agree that the submissions should likely not disappear and Canceled submissions should still be shown.
I left 2 small optional suggestions below. Feel free to disregard.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The new tooltips and icons look great!
Overview
This PR builds out the functionality to Cancel and Restore a Submission Request, and includes supporting QoL updates for related implementations.
Warning
Some implementation notes:
cancelApplication
instead ofdeleteApplication
since that's the correct terminologyChange Details (Specifics)
Related Ticket(s)
CRDCDH-2187 (Task)
CRDCDH-2146 (US 1)
CRDCDH-2142 (US 2)