Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Login Flow & Fix Navbar Button Styling #592

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jan 14, 2025

Overview

This PR addresses two primary things:

  • Login controller refactoring
  • Fix the alignment of the button-based sub-items (logout, cli tool, etc)
Navbar alignment issue

BEFORE (QA2): Look at the "g" in Login compared to the horizontal line

QA-Navbar

AFTER (DEV2): Look at the "g" in Login compared to the horizontal line

DEV-Navbar

USED FOR TESTING (insert inside the root element)

<hr style="
  position: fixed;
  left: 0;
  right: 0;
  z-index: 9999;
  top: 247.1px;
">

Change Details (Specifics)

(UX changes)

  • Fix the vertical and horizontal alignment of navbar buttons to match links

(Refactoring changes)

  • Rename the login content folder to Login
  • Refactor the login controller code to be cleaner and follow a more logical flow (opinion)
  • Return the SuspenseLoader from the LoginController
    • This is only visible briefly, but on slow internet connections, it looks smoother
  • Write test coverage for the login controller page

Related Ticket(s)

CRDCDH-2033 (Code Refactoring, the login flow will be retested here)
CRDCDH-2124 (I refactored the navbar here)

@amattu2 amattu2 added this to the 3.2.0 (PMVP-M3) milestone Jan 14, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 14, 2025

Pull Request Test Coverage Report for Build 12791107885

Details

  • 8 of 9 (88.89%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 57.726%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/router.tsx 0 1 0.0%
Totals Coverage Status
Change from base Build 12791079477: 0.1%
Covered Lines: 3954
Relevant Lines: 6421

💛 - Coveralls

@amattu2 amattu2 changed the title Refactor Login Controller, Fix Navbar dropdown alignment Refactor Login Flow & Fix Navbar Button Styling Jan 14, 2025
@amattu2 amattu2 marked this pull request as ready for review January 14, 2025 18:25
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit ab22a2a into 3.2.0 Jan 15, 2025
7 checks passed
@Alejandro-Vega Alejandro-Vega deleted the PBAC/navbar-fixes branch January 15, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants