Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-2021 Collaborators Dialog Updates #576

Open
wants to merge 6 commits into
base: pbac-update-user-roles
Choose a base branch
from

Conversation

Alejandro-Vega
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega commented Jan 2, 2025

Overview

Removed Organization and Access columns from Collaborators dialog table.

Note

The Collaborators dialog needs an updated description. Will update in future PR if still have not received updated text yet.

Note

Haven't tested with BE yet as it is not ready yet, but based my implementation on the existing BE PR.

Change Details (Specifics)

  • Removed the Organization and Access columns from Collaborators dialog table
  • All collaborators now always have a "Can Edit" permission
  • Updated Collaborator name to match BE formatting. (Otherwise it shows differently before and after saving a collaborator) (See https://github.com/CBIIT/crdc-datahub-backend/pull/527/files)
  • Removed any mention of user org and "Can View" permission
  • Looks like the org property still exists in Collaborator type on BE, just defaulted to null and removed it from being returned as it is not used on FE
  • Removed org property from the User type
  • Increased max characters before truncation from 10 => 35 due to extra space. Added comment in ticket.

Related Ticket(s)

CRDCDH-2021 (Task)
CRDCDH-1984 (US)

@Alejandro-Vega Alejandro-Vega added the 🚧 Do Not Merge This PR is not ready for merging label Jan 2, 2025
@Alejandro-Vega Alejandro-Vega added this to the 3.2.0 (PMVP-M3) milestone Jan 2, 2025
@Alejandro-Vega Alejandro-Vega requested a review from amattu2 January 2, 2025 19:52
@Alejandro-Vega Alejandro-Vega marked this pull request as ready for review January 2, 2025 19:52
@Alejandro-Vega Alejandro-Vega removed the 🚧 Do Not Merge This PR is not ready for merging label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant