CRDCDH-1995 Validation Results Aggregated/Expanded Table Views

[Alejandro-Vega]

Overview

Added Aggregated/Expanded view to the table in Validation Results tab in a Data Submission.

Note

The BE currently does not populate issue codes. (They all return as null) which breaks some functionality such as the issue type filter, "Expand" and button. There is also a BE bug when passing -1 for the "first" param of the aggregated submission QC results API.

Change Details (Specifics)

• Added switch to toggle between Aggregated and Expanded view
• Added additional filter "Issue Type" to filter by a specific issue code
• Defined table for Aggregated view. The Expanded view is the existing table
• Set default pagination to 20
• When user clicks on "Expand" button it should select the filter in the Issue Type dropdown and switch to Expanded view

Related Ticket(s)

CRDCDH-2037 (Aggregated View Task)
CRDCDH-1995 (Expanded View Task)
CRDCDH-1889 (US)

[coveralls]

Pull Request Test Coverage Report for Build 12813170611

Details

• 149 of 173 (86.13%) changed or added relevant lines in 6 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.3%) to 58.006%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/components/DataSubmissions/ExportValidationButton.tsx	46	50	92.0%
src/content/dataSubmissions/QualityControl.tsx	51	71	71.83%

Files with Coverage Reduction	New Missed Lines	%
src/content/dataSubmissions/QualityControl.tsx	1	72.08%

Totals
Change from base Build 12812387937:	0.3%
Covered Lines:	4031
Relevant Lines:	6519

---

💛 - Coveralls

[amattu2]

I tested it locally as best as I could and annotated a few comments. Feel free to dismiss any.

[amattu2]

Changes LGTM!

Everything seems to work, except the type filter and expand button (as noted). Feel free to merge when verified against the finished API.

[Alejandro-Vega]

@amattu2 The BE is now ready and working properly. I also made some slight changes so that the filters reset when toggling the table view in 7bda97e, so please review my changes and check if you find any issues that I couldn't. Otherwise, it seems good to go.

[amattu2]

@Alejandro-Vega It looks like Jest keeps failing (I tried rerunning it too). Could you check and see if it's related to these changes?

[Alejandro-Vega]

@Alejandro-Vega It looks like Jest keeps failing (I tried rerunning it too). Could you check and see if it's related to these changes?

Oops, thanks for catching that I forgot to rerun them at the end. I went ahead and fixed them in 136264d.

Also FYI, I did find one additional issue on the BE for Data File related errors. Their codes are returning null, but the Metadata related error codes are populated correctly. Still should be fine to merge though.

[amattu2]

All the changes still LGTM and it seems to work as expected.

---

I annotated a suggestion to skip the queries for the hidden filters when viewing aggregated view, which saves 3 network requests initially. The only downside is, when you toggle between aggregated/expanded, it will re-execute the queries every time instead of just once on mount (current implementation).

I'm unsure if it's worth the tradeoff, since I don't know how often people will switch between the views. With that being said, I'll defer to you for the decision on this.