CRDCDH-1861 Submission Request Content Adjustments

[amattu2]

Overview

This PR reorganizes some of the Submission Request content and includes minor QoL updates for the end users.

Note

This change, specifically the moving of the dbGaPID field, should be fully backwards compatible. I tested working on the same form "simultaneously" using DEV2 and locally, but it's possible I missed something when testing.

Change Details (Specifics)

Requirement based changes:

• Move dbGaPID field to Section C
  • Since dbGaPID is serialized inside the Study details, there's some migration code to ensure study data is properly stored.
  • Another option would be to pull dbGaPID out of study – Open to opinions on this
• Adjust max length of Funding Agency -> Grant field (Section B)
• Reorganize the last 3 inputs to make the Additional Comments box the last field in the form (Section D)
• Apply reorganization on the Review page (not explicitly called for, but inferred)

Related changes:

• Add error logging for saveApplication mutation and remove raw error details from the alert
• Bug fix for – User was unable to remove the last Planned Publication. This bug was not logged.

Unrelated changes:

• Remove unused files
  • config/ClinicalDataConfig.tsx
  • config/PreCancerTypesConfig.ts
  • useConditionalWrapper.tsx (Unused after CRDCDH-36 Implement Section C #27)

Related Ticket(s)

CRDCDH-1861 (FE Task)
CRDCDH-1846 (User Story)

[coveralls]

Pull Request Test Coverage Report for Build 12749851024

Details

• 0 of 13 (0.0%) changed or added relevant lines in 4 files are covered.
• 4 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.03%) to 56.679%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/components/Contexts/FormContext.tsx	0	1	0.0%
src/content/questionnaire/FormView.tsx	0	1	0.0%
src/content/questionnaire/sections/B.tsx	0	3	0.0%
src/content/questionnaire/sections/C.tsx	0	8	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/content/questionnaire/sections/B.tsx	1	0.59%
src/content/questionnaire/sections/Review.tsx	1	3.28%
src/components/Contexts/FormContext.tsx	2	71.56%

Totals
Change from base Build 12676325651:	0.03%
Covered Lines:	3833
Relevant Lines:	6313

---

💛 - Coveralls

[Alejandro-Vega]

Everything looks solid to me. I left one optional suggestion, but feel free to disregard it if it doesn't work or if you're fine with your existing implementation.

[Alejandro-Vega]

Pre-approving, everything LGTM! Feel free to merge once you resolve the discussion above.