Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-1740 Redesign History Dialog component #501

Draft
wants to merge 1 commit into
base: CRDCDH-1739
Choose a base branch
from

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Oct 18, 2024

Overview

This PR introduces a rewrite of the History Dialog's underlying component, which incorporates a design update and an additional field indicating which user performed the history transition.

Note

This design change impacts the Submission Request too, but the "User" column won't appear there since we don't get and userName from the getApplication API.

Change Details (Specifics)

  • Rewrite the History Dialog to be slightly more efficient (memoization and optimizing usage of callbacks, etc)
  • Rebuild the dialog UX without the MUI timeline (we essentially weren't using anything from it)
  • Minor updates to test coverage that was impacted by changes

Related Ticket(s)

CRDCDH-1740 (FE Task)
CRDCDH-1697 (User Story)

@amattu2 amattu2 added this to the 3.1.0 (PMVP-M2) milestone Oct 18, 2024
@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Do Not Merge This PR is not ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant