Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-1743 Implement "Request Access" form #499

Draft
wants to merge 3 commits into
base: 3.1.0
Choose a base branch
from
Draft

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Oct 17, 2024

Overview

This PR introduces a new feature for external users (User, Submitter, Org Owner) to request a role and/or organization change via their profile.

It also incorporates related DX QoL changes. See details below.

Note

I added a "StyledDialogComponents" folder, but did not migrate any existing dialogs to these prestyled components. If we get related work (bugs/tasks) for the dialogs, we can probably migrate them at that point.

Notes

[!NOTE]
FE todo:

  • See all todo comments
  • Fix dialog ACT warning (preventing testing)

[!NOTE]
Integration todo:

  • Check API against story
  • Verify it sanitizes HTML in the additionalComments/Org field

Change Details (Specifics)

  • Add a "Request Access" form for certain external user roles to request a specific role and organization assignment
  • Deduplicate the Autocomplete input field styling and create a component for it in the StyledFormComponents folder
  • Add the standard dialog components to a generic folder (similar to StyledFormComponents)
  • Create a new query specifically to fetch organization names, which is heavily cached once fetched

Related Ticket(s)

CRDCDH-1743 (Task)

@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Oct 17, 2024
@amattu2 amattu2 added this to the 3.1.0 (PMVP-M2) milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Do Not Merge This PR is not ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant