CRDCDH-1760 Dynamic Model Navigator Icon #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amattu2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes the Data Common logos out of CRDC-DH FE, and instead, migrates them to the CRDC-DH Models repo. If the repository does not specify a navigator logo to use, we will use a generic logo.
Note
Every Data Common is currently going to show as the generic logo until we update the CRDC-DH models repository (151). This PR does not depend on that change.
Change Details (Specifics)
titleIconSrcattribute from the DataCommons config / type defRelated Ticket(s)
CRDCDH-1760 (FE Task)
CRDCDH-1750 (User Story)