Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CDE cases #484

Merged
merged 2 commits into from
Oct 7, 2024
Merged

update CDE cases #484

merged 2 commits into from
Oct 7, 2024

Conversation

ty-esi
Copy link
Collaborator

@ty-esi ty-esi commented Oct 7, 2024

Overview

FE: Data Model Navigator - Access caDSR Permissible Values

Change Details (Specifics)

## Has CDE code and Version && retrieveCDE return permValues

- Render the permValues returned from `retrieveCDE`

## Has no CDE code and Version && has enum values defined in MDF

- Render the enum values defined in the MDF

## Has CDE code and Version && has enum values defined in MDF && retrieveCDE returns empty permValues 

- Render the fallback message

## Has CDE code and version && has no enum vales defined in MDF

- noop

## Has CDE code and Version && has enum values defined in MDF && retrieveCDE returns null for permValues

- use enums defined in mdf

## Has CDE code and Version && has no enum values defined in MDF && retrieveCDE returns null for permValues

- noop

Related Ticket(s)

https://tracker.nci.nih.gov/browse/CRDCDH-1443

@ty-esi ty-esi added this to the 3.1.0 (PMVP-M2) milestone Oct 7, 2024
@ty-esi ty-esi requested a review from amattu2 October 7, 2024 19:31
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and seems to work as expected, tested a few of the common scenarios to verify.

Thanks for the quick fix and nice work!

@amattu2 amattu2 enabled auto-merge October 7, 2024 20:37
@amattu2 amattu2 merged commit 761eb53 into 3.1.0 Oct 7, 2024
5 checks passed
@amattu2 amattu2 deleted the CRDCDH-1443-II branch October 7, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants