Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-1632 Data Curator Data Commons assignment #472

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Sep 19, 2024

Overview

This PR updates the Data Curator implementation to add Data Commons assignment, identical to Data Commons POC functionality.

Note

This feature is still waiting for BE updates including:

  • Allow assignment of Data Commons to a Curator
  • Update the on save error message when a DC is not assigned

But the PR can be merged without these changes.

Change Details (Specifics)

  • Require Data Commons for Data Curators
  • Hide Organization field for Data Curators
  • Update ProfileView to support a hidden Organization field (previously wasn't necessary)
  • Update misc. test coverage for these changes

Related Ticket(s)

CRDCDH-1632 (FE Task)
CRDCDH-1567 (User Story)

@amattu2 amattu2 changed the title CRDCDH-1632 Support Data Curator Data Commons assignment CRDCDH-1632 Data Curator Data Commons assignment Sep 19, 2024
@coveralls
Copy link
Collaborator

coveralls commented Sep 19, 2024

Pull Request Test Coverage Report for Build 10995982463

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 47.354%

Totals Coverage Status
Change from base Build 10995960615: 0.04%
Covered Lines: 2790
Relevant Lines: 5339

💛 - Coveralls

@amattu2 amattu2 modified the milestone: 3.1.0 (PMVP-M2) Sep 19, 2024
@amattu2 amattu2 marked this pull request as ready for review September 20, 2024 13:38
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit 43209c6 into 3.1.0 Sep 23, 2024
6 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-1632 branch September 23, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants