-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRDCDH-1501 Create/Edit Pre-Approved Study Page #469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job putting this together. Great to see the test coverage for the StudyView, I'm sure that was a large effort. I annotated some issues and also some recommendations below.
FYI,
The backend isn't updating any external references to the study. e.g. If you change the abbreviation, it doesn't update any Data Submissions that use the study. The requirements don't explicitly call for this, but I would think it's assumed? Could be wrong though.
Co-authored-by: Alec M <[email protected]>
Co-authored-by: Alec M <[email protected]>
Co-authored-by: Alec M <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Overview
Created page for creating and editing approved studies. This will be in the Admin dashboard and can be accessed through the Manage Studies page.
Change Details (Specifics)
ORCID
and make sure at least oneAccess Type
is selected, otherwise it will show an error.ORCID
like in Submission RequestdbGaP
input is only required if "Controlled Access" is selectedRelated Ticket(s)
CRDCDH-1501 (Create Study Task)
CRDCDH-1488 (Create Study User Story)
CRDCDH-1502 (Edit Study Task)
CRDCDH-1485 (Edit Study User Story)