-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRDCDH-1517 Add additional tooltips to Data Submission Dashboard #464
Conversation
Pull Request Test Coverage Report for Build 10911450077Details
💛 - Coveralls |
This comment was marked as outdated.
This comment was marked as outdated.
… and submitter logic and added tests for each
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job with the submit action button refactoring. Extracting the ruleset to a config file will make it much easier in the future to add/edit rules.
I annotated a few suggestions, none of which are critical or show stoppers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice job
Overview
Added additional tooltips to the Validation control options as well as workflow buttons.
Change Details (Specifics)
required
property to ensure some conditions won't be bypassed by the admin overrideSubmit button logic:
Enable submit button conditions: (NOTE: 'Initialized' = not null)
Admin Override submit button conditions: (It cannot override required conditions)
Related Ticket(s)
CRDCDH-1517