Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-1583 UX QA for Submission Requests #462

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Sep 9, 2024

Overview

This PR addresses UX QA issues identified for the Submission Requests pages.

Change Details (Specifics)

(Changes by UX QA comment number)

  • Comment 60 (a822df4)
    • Replace the Submission Request List page banner with the latest one (unsure when it became outdated)
    • Delete the old banner
  • Comment 65/66 (f741088)
    • The vertical alignment of the Status Bar headers (Status/Last updated) were not exactly lined up with the values
    • Also fixed a 508 audit warning that we were skipping headers (e.g. Going from H1 > H5)
  • Comment 72 (277625b)
    • Fixed an alignment issue with the Data Types checkboxes not going edge-to-edge
    • Also reduced the margin between columns per UX design
  • Comment 79 (34e596a)
    • The horizontal divider on the Review page was using color instead of background causing it to not reflect the design

Related Ticket(s)

CRDCDH-1583 (Task)
CRDCDH-1478 (User Story)

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10775563370

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 46.274%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Questionnaire/SwitchInput.tsx 1 2 50.0%
Totals Coverage Status
Change from base Build 10775144544: -0.009%
Covered Lines: 2695
Relevant Lines: 5275

💛 - Coveralls

@amattu2 amattu2 added this to the 3.1.0 (PMVP-M2) milestone Sep 9, 2024
@amattu2 amattu2 marked this pull request as ready for review September 9, 2024 16:25
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit ebceb08 into 3.1.0 Sep 12, 2024
6 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-1583 branch September 12, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants