Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDCDH-1584 Navbar UX QA #460

Merged
merged 9 commits into from
Sep 9, 2024
Merged

CRDCDH-1584 Navbar UX QA #460

merged 9 commits into from
Sep 9, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Sep 5, 2024 •
edited
Loading

Overview

This PR addresses a small UX QA issue identified with the Navbar font weight.

Change Details (Specifics)

  • Update navbar item font-weight from 700 down to 600
  • Remove unused font files that aren't referenced anywhere
  • Migrate GenericAlert for auth errors to useSnackbar

Related Ticket(s)

CRDCDH-1584 (Ticket)
CRDCDH-1515 (User Story)

@coveralls
Copy link
Collaborator

coveralls commented Sep 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10774092265

Details

  • 18 of 19 (94.74%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.7%) to 46.283%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/DataSubmissions/CopyAdornment.tsx 9 10 90.0%
Files with Coverage Reduction New Missed Lines %
src/components/GenericAlert/index.tsx 2 55.17%
Totals Coverage Status
Change from base Build 10702810869: 0.7%
Covered Lines: 2695
Relevant Lines: 5274
💛 - Coveralls

@amattu2 amattu2 added this to the 3.1.0 (PMVP-M2) milestone Sep 5, 2024
@amattu2
fix: UX QA Issue 87
2529305 
Also migrate Copy Submission ID to independent component
@amattu2
fix: UX QA Issue 86
b4b924a
@amattu2
fix: UX QA Issue 89
7854b5f 
Migrate Submission Request History Dialog to shared component
@amattu2
Add coverage for HistoryDialog
d376dfe
@amattu2
Fix typo
0708859
Alejandro-Vega
Alejandro-Vega requested changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM! Left one small optional change.

src/components/Header/index.tsx Outdated Show resolved Hide resolved
@Alejandro-Vega Alejandro-Vega added the 📝 Change Requested This PR has requested changes label Sep 6, 2024
@amattu2 amattu2 removed the 📝 Change Requested This PR has requested changes label Sep 9, 2024
@Alejandro-Vega Alejandro-Vega merged commit add19a3 into 3.1.0 Sep 9, 2024
6 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-1584 branch September 9, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alejandro-Vega Alejandro-Vega Alejandro-Vega approved these changes

@ty-esi ty-esi Awaiting requested review from ty-esi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0 (PMVP-M2)
Development

Successfully merging this pull request may close these issues.
3 participants
@amattu2 @coveralls @Alejandro-Vega