Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-1206 Submitted Data > Support "Data Files" Viewing #401

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jun 10, 2024

Overview

This PR extends the previous Submitted Data implementation to support the "Data Files" node type, among other minor changes.

Change Details (Specifics)

  • Change the ExportNodeDataButton tooltip to be dynamic based on if metadata or data files is selected
  • Add Status (validation status) column to the table and exported TSV file
  • Allow "data file" to appear in the node type filter
  • Force the nodeName to appear as lowercase in the dropdown
  • Update misc. test cases for changes

Related Ticket(s)

CRDCDH-1206

@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Jun 10, 2024
@amattu2 amattu2 added this to the 3.0.0 (PMVP-M1) milestone Jun 10, 2024
@coveralls

This comment was marked as off-topic.

@coveralls

This comment was marked as outdated.

@amattu2 amattu2 marked this pull request as draft June 14, 2024 18:59
@amattu2 amattu2 changed the title CRDCDH-1206 Submitted Data > Support Data Files Viewing CRDCDH-1206 Submitted Data > Support "Data Files" Viewing Jun 17, 2024
@amattu2 amattu2 marked this pull request as ready for review June 21, 2024 19:31
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Jun 21, 2024
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit c6bd370 into 3.0.0 Jun 24, 2024
5 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-1206 branch June 24, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants