Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix silent warnings allowing Jest to succeed #398

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jun 6, 2024

Overview

This PR prevents console.warn and console.error calls from silently happening in tests and not failing the Jest action for it.

Change Details (Specifics)

  • Add jest-fail-on-console dependency

Related Ticket(s)

N/A

@coveralls

This comment was marked as outdated.

@coveralls
Copy link
Collaborator

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9404799472

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 30.969%

Totals Coverage Status
Change from base Build 9404076520: 0.0%
Covered Lines: 1583
Relevant Lines: 4376

💛 - Coveralls

Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit 870a77b into 3.0.0 Jun 7, 2024
6 checks passed
@Alejandro-Vega Alejandro-Vega deleted the dx-fix-silent-warnings branch June 7, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants