Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-1118 Export Submitted Data to TSV #386

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented May 28, 2024

Overview

This PR extends the Data Submission > Submitted Data tab with the functionality to download the current node to TSV.

Warning

Merging this won't break anything, but it won't work until the API supports -1 pagination. If testing locally, just change the query from -1 to 1000 or something large.

Change Details (Specifics)

  • Fix GenericTable duplicate aria-label for table paginations when the navigation is specified as both
  • Create ExportNodeDataButton with functionality to export ALL data for the selected Node
  • Add test coverage for ExportNodeButton
  • Add type definition for getNodeData input parameters

Related Ticket(s)

CRDCDH-1118

@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label May 28, 2024
@amattu2 amattu2 added this to the 3.0.0 (PMVP-M1) milestone May 28, 2024
@amattu2 amattu2 marked this pull request as ready for review May 30, 2024 17:11
@amattu2 amattu2 requested a review from Alejandro-Vega May 30, 2024 19:41
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label May 30, 2024
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works as expected.

@Alejandro-Vega Alejandro-Vega merged commit b1561d5 into 3.0.0 Jun 4, 2024
5 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-1118 branch June 4, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants