Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-960 Fix boolean value parsing of Req property #322

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Mar 25, 2024

Overview

This PR upgrades our Data Model Navigator version which includes updated parsing of boolean values for Data Model Properties Req property.

See updated code here – CBIIT/Data-Model-Navigator@7b98d69

Before & After

Before: Screenshot 2024-03-25 at 11 11 44 AM

After:

Screenshot 2024-03-25 at 11 12 28 AM

Testing Change

  1. Run the branch
  2. Go to Data Model Navigator
  3. CDS Model
  4. Click on the Table View tab
  5. Scroll to the bottom and find Data File > Image
  6. Look at the "license" property

Change Details (Specifics)

  • Update Model Navigator dependency

Related Ticket(s)

CRDCDH-960

@amattu2 amattu2 added this to the 2.1.0 (MVP2-M3) milestone Mar 25, 2024
@amattu2 amattu2 changed the title CRDCDH-960 Fix boolean value parsing of Model Props Req Property CRDCDH-960 Fix boolean value parsing of Req property Mar 25, 2024
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit e74158e into mvp-2.1.0 Mar 25, 2024
3 checks passed
@Alejandro-Vega Alejandro-Vega deleted the 2.1.0/CRDCDH-960 branch March 25, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants