Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDCDH-864 Fix broken aria references and contrast issue #291

Merged
merged 2 commits into from
Feb 28, 2024
Merged

CRDCDH-864 Fix broken aria references and contrast issue #291

merged 2 commits into from
Feb 28, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Feb 28, 2024

Overview

This PR addresses broken aria references on the CLI Uploader Tool and CLI API Token dialogs.

Change Details (Specifics)

  • Override the default random aria-labelledby ID generated by MUI
  • Replace h3/h6 headings with h1/body1 respectively (addresses a 508 warning)
  • Fix button contrast issue on API Token download dialog

Related Ticket(s)

CRDCDH-864

@amattu2 amattu2 added this to the MVP-2.1.0 (M3) milestone Feb 28, 2024
Alejandro-Vega
Alejandro-Vega approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit da9edd1 into mvp-2.1.0 Feb 28, 2024
1 check passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-864 branch February 28, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alejandro-Vega Alejandro-Vega Alejandro-Vega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0 (MVP2-M3)
Development

Successfully merging this pull request may close these issues.
2 participants
@amattu2 @Alejandro-Vega