Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-678 Data Submission Review Comments #283

Merged
merged 13 commits into from
Feb 16, 2024
Merged

CRDCDH-678 Data Submission Review Comments #283

merged 13 commits into from
Feb 16, 2024

Conversation

Alejandro-Vega
Copy link
Collaborator

Overview

Added Review Comments button in Data Submission Dashboard. It will only show latest comment for Rejections.

Change Details (Specifics)

  • Added Review Comments button
  • Disabled Review Comments button if not comment is available, instead of hiding button
  • Only Rejection reviewComments should be displayed, Admin submit reviewComments should never be shown
  • Updated spacing and styling in Summary section
  • Reused Review Comments dialog from Questionnaire, with some changes and moved to a shared folder
  • Updated questionnaire to use new shared component for dialog
  • Updated questionnaire tests
  • Added tests for Data Submission Summary section and new Review Comments dialog component

Related Ticket(s)

CRDCDH-678

Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job (as always). Two design related questions added, and only one code-related issue.

This warning/error is appearing in the console:

Warning: React does not recognize the `getColorScheme` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `getcolorscheme` instead. If you accidentally passed it from a parent component, remove it from the DOM element.

Everything else LGTM.

src/components/DataSubmissions/DataSubmissionSummary.tsx Outdated Show resolved Hide resolved
src/components/DataSubmissions/DataSubmissionSummary.tsx Outdated Show resolved Hide resolved
@amattu2 amattu2 merged commit aad3ca6 into mvp-2.1.0 Feb 16, 2024
1 check passed
@amattu2 amattu2 deleted the CRDCDH-678 branch February 16, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants