Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-633 508 Compliance Audit (v2) #270

Merged
merged 10 commits into from
Jan 25, 2024
Merged

CRDCDH-633 508 Compliance Audit (v2) #270

merged 10 commits into from
Jan 25, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jan 24, 2024

Overview

This PR introduces fixes for 508 color contrast issues found in the first Audit and for new issues introduced in recent feature development.

Change Details (Specifics)

  • Update Data Model Navigator package (CBIIT/Data-Model-Navigator@ea5a199)
  • Remove mostly-unused MUI color palette for Submission Request components
  • Fix color contrast on History Popup Pre-Title (used in Submission Req. and Data Sub.)
  • Fix asterisk contrast issues in some contexts (same color applied across the board)
  • Fix "no content" messages on all tables
  • Fix file count and upload error link text contrast in Data Submission / Upload tab on alternate rows
  • Fix "View" submission request button color contrast
  • Fix "Create Submission Request" and "Create Organization" button color contrast
  • Partial fix for Data Submission statistics (see below note)

Note

The Data Submission Statistics still have 508 issues due to the carousel's native functionality. Will look into this further in CRDCDH-538

Note

Some buttons throughout the app have color contrast issues. This will most likely be fixed by CRDCDH-747

Related Ticket(s)

CRDCDH-633

@amattu2 amattu2 added this to the MVP-2.1.0 (M3) milestone Jan 24, 2024
@amattu2 amattu2 marked this pull request as ready for review January 25, 2024 14:10
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice job!

@Alejandro-Vega Alejandro-Vega merged commit 04fe26e into mvp-2.1.0 Jan 25, 2024
1 check passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-633 branch January 25, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants